Abstract ordering clause of query builder and implement BM25 support on top of it #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unctionality within the OrderingClause abstraction.
|
|
||
| /** | ||
| * Retrieve the current {@link OrderingClause} as a {@link ColumnsOrderingClause} if it exists and | ||
| * is an instance of this class, Otherwise create a new one. |
There was a problem hiding this comment.
So this means that if there is an existing custom-type OrderingClause, that is dropped?
I assume it is ok wrt ANN and BM25 as they cannot be combined with "regulard" ORDER BY clauses but could maybe hide issues?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR first consolidates handling of column ordering into an OrderingClause type and re-implements existing orderings using that type. We then demonstrate how this implementation can be used to implement custom orderings, specifically the BM25 ordering provided by Astra.